Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Faster enumeration of active items."
Purpose of change
In profiling while waiting in an empty area of map, 17% of samples occurred in map::process_items().
Upon analyzing the code it became clear that this time was being spent scanning the map for vehicles and active items. This was tolerable when the map was 2D, but now that it's 3D by default, it is way too expensive.
Describe the solution
Use the existing vehicle list cache to enumerate submaps that contain vehicles.
Add a cache of submaps that directly contain active items.