Ups flag fix #31388
Merged
Ups flag fix #31388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rail-Runner
reviewed
Jun 13, 2019
| @@ -16,7 +16,7 @@ | |||
| "type": "TOOLMOD", | |||
| "category": "spare_parts", | |||
| "name": "UPS conversion mod", | |||
| "description": "This device replaces conventional battery connections with a rechargeable power cell that runs off of a Unified Power System. Having the UPS on or placing a tool in a special recharging station will slowly charge it.", | |||
| "description": "This device replaces conventional battery connections with a connector port that can plug into a UPS. Any device modified with this can be used without a battery as long as you have a charged UPS with you", | |||
There was a problem hiding this comment.
Missed a period on end.
Suggested change
| "description": "This device replaces conventional battery connections with a connector port that can plug into a UPS. Any device modified with this can be used without a battery as long as you have a charged UPS with you", | |
| "description": "This device replaces conventional battery connections with a connector port that can plug into a UPS. Any device modified with this can be used without a battery as long as you have a charged UPS with you.", |
|
Unless something has changed recently there's more tools broken. Last I tested the Survivor Headlamp, Electric Chainsaw and Soldering Iron (used to repair things) don't function correctly. There could also be more. I think I recall someone mentioning the mess kit not working for heating up food. |
|
Survivor headlamp is the same bug as I reported. Chainsaw probably also qualifies. The soldering iron I will need to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Removed non-functional RECHARGE flag from UPS"Purpose of change
Closes #31308
Describe the solution
The UPS can no longer be charged in recharging stations directly. Instead, the battery can be removed, and that may be recharged. This is intended behavior, but the RECHARGE flag implied otherwise. I removed the flag so that people don't think the UPS can be recharged directly anymore (It cannot, and this is intentional)
I also adjusted the description of the UPS conversion mod to be more accurate because why not?
Describe alternatives you've considered
N/A
Additional context
Before yesterday, I was under the impression that the UPS was a lot more broken than it actually is. I thought that it simply didn't work on most tools. You can blame this on poor testing from me. Other than #31377, which I would call a "minor bug", most tools work just fine with UPS conversion mods, and frankly, after my testing, I'm convinced that the UPS is in a pretty good place, balance wise and usability wise.