Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX and MXE Windows builds #31385

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Fix OSX and MXE Windows builds #31385

merged 4 commits into from
Jun 13, 2019

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Follow-up after #31361.

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jun 13, 2019
@ZhilkinSerg ZhilkinSerg changed the title Fix OSX builds Fix OSX and MXE Windows builds Jun 13, 2019
@ZhilkinSerg ZhilkinSerg added the OS: Windows Issues related to Windows operating system label Jun 13, 2019
src/mingw.thread.h Outdated Show resolved Hide resolved
src/mingw.thread.h Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg merged commit 8238d5a into master Jun 13, 2019
@ZhilkinSerg
Copy link
Contributor Author

I think we are good here. Self merging to see if it helped or we need some more fixes.

@ZhilkinSerg ZhilkinSerg deleted the refactor-casts-osx-mxe branch June 13, 2019 11:14
@jbytheway
Copy link
Contributor

Thanks for following up :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style OS: macOS Issues related to macOS / OSX operating system OS: Windows Issues related to Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants