Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuel fires while waiting #31364

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Jun 12, 2019

Summary

SUMMARY: Bugfixes "Refuel fires while waiting."

Purpose of change

Fixes #31277

Describe the solution

add the missing "refuel_fires": true field to ACT_WAIT

Describe alternatives you've considered

Not fixing it ¯\_(ツ)_/¯

@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics labels Jun 12, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Jun 12, 2019
@ZhilkinSerg ZhilkinSerg merged commit 9873da9 into CleverRaven:master Jun 12, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 12, 2019
@ifreund ifreund deleted the wait-refuel branch June 12, 2019 17:12
@jbytheway
Copy link
Contributor

The description of the firewood source specifically says that it won't be used if you're just waiting, but only if engaged in an activity that requires light. I think this was a deliberate choice, so as to preserve fuel. If we have changed our minds about that, then the description needs updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marked firewood source is not used for oven fire
3 participants