fix crash when drawing skills tab because of an unitialised variable #31342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unitialised variable
|
It's 100% worth doing a PR, thanks for fixing this. |
ifreund
added
<Bugfix>
ZhilkinSerg
reviewed
Jun 11, 2019
src/player_display.cpp
Outdated
| @@ -1301,7 +1301,7 @@ Strength - 4; Dexterity - 4; Intelligence - 4; Perception - 4" ) ); | |||
| catacurses::refresh(); | |||
|
|
|||
| int curtab = 1; | |||
| size_t min, max; | |||
| size_t min = 0, max = 0; | |||
There was a problem hiding this comment.
Please :)
Suggested change
| size_t min = 0, max = 0; | |
| size_t min = 0; | |
| size_t max = 0; |
|
with this commit it works fine but still doesn't show the speed alterations in the "speed" tab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue when built with gcc/clang introduced by 065310a
Additional context
Is it worth doing a PR for something this small? thought I'd go ahead and do it anyway since it seemed easier than opening an issue