Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move get_heat_radiation() to avoid duplicate calls #31329

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Move get_heat_radiation() to avoid duplicate calls #31329

merged 1 commit into from
Jun 11, 2019

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Found a really wasteful call pattern, get_heat_radiation( pos, false ) always returns the same value here, so no need to call it more than once.

Describe the solution

Just call it once.

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 11, 2019
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Performance Performance boosting code (CPU, memory, etc.) Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics labels Jun 11, 2019
@ZhilkinSerg ZhilkinSerg merged commit 2e67a68 into CleverRaven:master Jun 11, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 11, 2019
@kevingranade kevingranade deleted the avoid-refetching-heat branch June 12, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Performance Performance boosting code (CPU, memory, etc.) Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevingranade @ZhilkinSerg