Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another camp bug with expansions not showing up #31255

Merged
merged 3 commits into from Jun 9, 2019
Merged

Fix another camp bug with expansions not showing up #31255

merged 3 commits into from Jun 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 8, 2019

Summary

SUMMARY: Bugfixes "Camp expansions not showing up on menu - fix"

Purpose of change

The previous fixes for this issue, fixed it, but only when loading a savegame.
straight after building, the expansion didnt show up in the menu, this fixes that.

Describe the solution

Update_resources was being run in parse_expansion()
the expansions map had not been updated yet , therefore it didnt loop through the expansions properly.
Ive moved update_resources after the expansions map has been updated.

Describe alternatives you've considered

N/A

Additional context

N/A

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 9, 2019
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site labels Jun 9, 2019
@ZhilkinSerg ZhilkinSerg merged commit d76f9d1 into CleverRaven:master Jun 9, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 9, 2019
@ghost ghost deleted the yet_another_camp_fix branch September 11, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant