Various Corrections of Spelling and Clarification of Quests #31216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct typos - Reformat quest names to be clearly identify what is required and remove questgiver (quests already specify the questgiver - "Bring items to John Doe for John Doe") - Replace UK English with US English as specified by MANUAL_OF_STYLE.md
- Format quests so they don't read as "Do X for NPC Y for NPC Y", and now properly read as "Do X for NPC Y" - Update UK English with US English - Clarified quest items in quest for actual item needed rather than being unclear
DracoGriffin
added
NPC / Factions
ZhilkinSerg
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Correct typos and update spelling to US English per manual. Altered quests to be less redundant and more clear in the objective.
Additional context
Quest related --- quests have
for NPC_quest_giverappended to the end of quest names automatically in-game.For Fatima's quest:
"name": "Find a copy of the Quran for Fatima",shows up as
Find a copy of the Quran for Fatima for Fatima al Jadir, refugeeAfter fix will show up as:
Find a copy of the Quran for Fatima al Jadir, refugeeLikewise for fetch missions, having unclear items and amounts is annoying, mainly for Dino Dave:
"name": "Bring Dino Dave small cardboard boxes.",After fix will show up as:
Bring 40 small cardboard boxes for Dino Dave, beggarSome of these could be re-worded to be slightly more clear, for instance:
Bring 40 small cardboard boxes for Dino Dave, beggarcould be changed to
Bring back 40 small cardboard boxes for Dino Dave, beggarbut wasn't sure how needful that may be.