basecamps: add a namespace and calculate workdays #31194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reorganize the basecamp code slightly by adding a base_camps:: namespace and moving various bits of code into it.
NPCs will work on a single task for up to 11 hours, but on longer tasks, they'll only work 10 hours out of every 24. Add functions to calculate the workload from the raw task times, and update most of the existing blueprints.
some basecamps were improperly saved without the blueprint_provides for the initial blueprint for their expansions, and therefore can't get any missions for that expansion. dpwb implemented a fix for the current existing expansions, but generalize that fix to handle future expansions.
mlangsdorf
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "basecamps: add a namespace and calculate workdays"Purpose of change
As part of #31115, split out a reviewable chunk of the code for merging.
Give basecamps a namespace for functions that are basecamp related but do not need to be in teh basecamp class.
Revise camp construction times to be absolute times in the JSON files, and have NPCs work on a single task for up to 11 hours, but break longer tasks into 10 hour workdays for every 24 hours.
Describe the solution
This is pretty straightforward:
Describe alternatives you've considered
I've written this code a couple of different ways and I will probably write it a few more.
Additional context
Part of #31115