Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motocross bikes and street-legal dirt bikes #31169

Merged

Conversation

kristleifur
Copy link
Contributor

Summary

SUMMARY: Content: "Add motocross and street-legal dirt bikes"

Purpose of change

I wanted to add my Husaberg FE 570 to the game. It's a big-bore street-legal dirt bike. Similar to the KTM 500 EXC and 690 Enduro R, or Husqvarna 501 / 701. Around 120kg wet weight, max speed north of 150 kph.

Describe the solution

Added a high-powered water-cooled single-cylinder motor. Added some lightweight and fragile motorcycle components to get the weight to an accurate level.

The street-legal bike is 121kg in-game, basically the same as a real plated dirt bike. Top speed is very similar. (The in-game street-legal dirt bike tops out at 144kph. A powerful dirt bike if pushed hard will go up to, say, 160kph.)

Also corrected the offroad motorcycle wheel diameter. The rims are usually 21" in front and 18" in the rear, but the rear tire is thicker so it evens out. Given the wheel sizes in the game 20" seems appropriate.

Also added an MX bike that weighs a bit less and has no headlight or horn.

Finally, there has been a pedal-powered Dirt bike in the game. I only know that term as referring to a combustion-engine powered offroad motorcycle. So renaming the pedal-powered dirt bike to Mountain bike?

Additional context

This sort of bike:
BFZQAZNA5QBTNK6RLUY5O6T3S4

In-game:
Uploading Screenshot 2019-06-06 at 00.25.30.png…
Screenshot 2019-06-06 at 00 25 23

Commit messages

  • add motocross bike and Street-Legal Dirt Bike (aka enduro bike – the
    enduro bike is similar to the mx bike but has a headlight and a stronger
    subframe so it can hold a bit of cargo)
  • add mx/enduro motorcycle spawns to some locations
  • add modern watercooled big-bore dirt bike engine. 550cc, 55HP, fuel
    consumption same as the 50hp V-Twin (a 50hp v-twin would be air-cooled and less
    fuel efficient)
  • add motorcycle headlight (lightweight and somewhat fragile)
  • change dirt bike wheel diameter to 20"
  • rename pedal-powered 'Dirt bike' to 'Mountain bike'

* add modern watercooled big-bore dirt bike engine. 550cc, 55HP, fuel
consumption same as the 50hp V-Twin (which would be air-cooled and less
fuel efficient)
* add motorcycle headlight (lightweight and fragile)
* change dirt bike wheel diameter to 20"
* add motocross bike and Street-Legal Dirt Bike (aka enduro bike – the
enduro bike is similar to the mx bike but has a headlight and a stronger
 subframe so it can hold a bit of cargo)
* add mx/enduro motorcycle spawns to some locations
* rename pedal-powered 'Dirt bike' to 'Mountain bike'
@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Jun 6, 2019
@mlangsdorf
Copy link
Contributor

Dirt bike is or used to be American slang for a cheap mountain/off-road bicycle. If mountain bike is the preferred term, go ahead and change it.

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 7, 2019
Copy link

@WhiteHusky WhiteHusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to rename the item.

data/json/items/vehicle/lights.json Outdated Show resolved Hide resolved
@kevingranade
Copy link
Member

Needs styling.

@ZhilkinSerg ZhilkinSerg merged commit 37a6167 into CleverRaven:master Jun 9, 2019
@kristleifur
Copy link
Contributor Author

kristleifur commented Jun 9, 2019

Thanks all! Am learning as I go! I am committed to needing less assistance and cleanup as I learn more :)

�- If the Dirt Bike as pedal powered bike turns out to be a New England idiom then let's switch it back by all means! I don't have a great feeling for geographic idiom use in US English :)

@ZhilkinSerg ZhilkinSerg removed their assignment Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants