Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Correct behavior of 3D shadowcasting mode"
Purpose of change
3D shadowcasting has a number of rendering bugs remaining, fix them.
A non-exhaustive list:
As in #29175 shockers are sometimes able to see and target you through a floor. With some debugging I determined the cause to be 3D shadowcasting.
When standing cardinally adjacent to a single opaque tile (wall or adult tree, etc), in 2D shadowcasting the area behind the tree is obscured, but in 3D it is visible.
When standing adjacent to a wall corner, in 2D shadowcasting the first tile of the wall is visible and the rest is occluded, in 3D the entire wall and anything behind it is visible.
3D shadowcasting does not cast directly up or down, so there's a shadow directly above and below the player.
Describe the solution
This is going to be a progressive process since I don't know what the problem is.