Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: Enable modernize-use-using #30805

Merged
merged 1 commit into from
May 24, 2019

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

For consistency in typedef vs using.

Followup to #30801.

Describe the solution

Enable the relevant clang-tidy check.

For consistency in typedef vs using.
@ZhilkinSerg ZhilkinSerg added the Code: Build Issues regarding different builds and build environments label May 24, 2019
@ZhilkinSerg
Copy link
Contributor

Random observation: there are still typedefs mentioned in a couple of comments.

@ZhilkinSerg ZhilkinSerg self-assigned this May 24, 2019
@jbytheway
Copy link
Contributor Author

Random observation: there are still typedefs mentioned in a couple of comments.

Yeah, that's unfortunate, but I don't think there's a better name for these constructs. They are still typedefs, just not defined with the typedef keyword.

@ZhilkinSerg ZhilkinSerg merged commit 118324b into CleverRaven:master May 24, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 24, 2019
@jbytheway jbytheway deleted the clang_tidy_use_using branch May 24, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants