Build chkjson on Travis #30802
Merged
Build chkjson on Travis #30802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging CleverRaven#30759 broke the build by introducing a compile failure in chkjson. This should be built on Travis to allow detection of such issues. Previously chkjson was only built on Jenkins, but that doesn't happen when the Makefile changes, so this problem went undetected.
ZhilkinSerg
added
the
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Verify that chkjson compiles on Travis"
Purpose of change
Merging #30759 broke the build by introducing a compile failure in
chkjson. This should be built on Travis to allow detection of such
issues.
Previously chkjson was only built on Jenkins, but that doesn't happen
when the Makefile changes, so this problem went undetected.
Describe the solution
When
$TEST_STAGEis set (i.e. for the first Travis build), also buildchkjson.Describe alternatives you've considered
Maybe we could merge
chkjsonwithjson_formatter? I'm not quite sure why both exist.