Set clang-tidy header filter #30799
Merged
Set clang-tidy header filter #30799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous, more generous filter would report issues in SDL headers in some cases.
ZhilkinSerg
added
the
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
The previous, more generous filter would report issues in SDL headers in some cases.
Describe the solution
Restrict to files in
srcortest, so as not to report problems in other files.Describe alternatives you've considered
There are a couple of other headers (like
tools/format/getpost.h) but I'm not worrying about those.Additional context
This isn't great as-is. Depending on people's directory layout it could still report errors in SDL headers (e.g. if they're in
~/src/sdlor something like that) but short of renaming oursrcdirectory to something cata-specific, I think this is the best option for now.