Travis tweaks #30761
Closed
Travis tweaks #30761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still want to test the CMake build, but this was two clang 6 builds; move the CMake test to another build so we can remove the clang-6 one.
Use the clang-3.8 build as a Linux tiles build for PRs instead.
Use the gcc-5.3 build to test building with LOCALIZE=0.
|
ahhhh I thought you weren't interested in doing this. |
ZhilkinSerg
added
the
Code: Build
|
Well, at a glance I think I prefer yours, but I encourage you to add some documentation in the |
|
Yea I'm just going to steal yours 👍 |
|
So, I guess we can close this in favor of Kevins PR or will you repurpose it for something else later? |
|
I THINK now that mine has the strategy laid out, it has a superset of the functionality of this one. @jbytheway let us know if there's anything else you want to save from this. |
ZhilkinSerg
pushed a commit
that referenced
this pull request
May 24, 2019
* Adjust coverage of Travis builds Attempt to get in all the configurations we really care about in PR tests. Max and Min versions of supported compilers. A mix of Curses and Tiles/Sound builds. A mix of Make and CMake builds. Localization disabled. The most popular (Tiles/Sound) Mac and Windows builds. Address sanitization enabled on latest GCC and Clang. Clang-tidy build. Finally, round out all the remaining supported compiler versions only on master builds, along with the somewhat obscure Mingw-w64 Terminal build. * Fix clang 8 install * Outline travis build target strategy Taken from #30761 * Add a new build stage
|
I agree; closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
After #30707 we lost some Travis builds I felt to be important. Rearrange things a bot more carefully.
Describe the solution
.travis.ymlthe things we're trying to cover with the builds we have.Overall, that's one build more than before this PR; two fewer than before #30707.
Describe alternatives you've considered
Disabling the 'default' Linux Tiles build may be controversial, but it was the best compromise I could find; all aspects of that build were being tested elsewhere and I don't think I've ever seen it be the only build to surface an issue.