Changed weight and volume values of the ferromagnetic rail ammo to be more realistic. #30752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing wrong with the PR itself, but the title was a little scary until I realized you were only adjusting one or two items. The title of the PR implies a much greater scope. Might be worth changing it. |
|
Oops! My bad, bit of an oversight. |
Greevv
changed the title
ZhilkinSerg
added
Items: Ammo / Guns
|
I accounted for that in the final numbers. Thanks for the concern though.
…On Thu, May 23, 2019, 2:23 AM eilaattwood ***@***.*** wrote:
Wait, 'count' parameter is still there, right? So, specified volume is
still for stack of 10? Should be multiplied by 10 then...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30752?email_source=notifications&email_token=AIERJQH7W6CMJTTA6DOO77DPWYZ43A5CNFSM4HOVP7HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWBGCZI#issuecomment-495083877>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIERJQE7SUOOCJMELVISNGTPWYZ43ANCNFSM4HOVP7HA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Changes the volume and weights of the ferromagnetic rails to be more realistic."
Purpose of change
The values for the volume and weights of the rail projectiles were unrealistically high. This is a fix for issue #30750.
Describe the solution
Simply tweaked the values in the JSON to better represent the actual volume and weights of a realistically sized projectile for a handheld railgun.
Describe alternatives you've considered
None.
Additional context
Source for the volume of the projectiles is here. I used dimensions of 6mm in diameter and 76.2mm (3 inches) in length.
Using a value of roughly 2 cm^3 or 2mL, I calculated the approximate weight of these projectiles using the density of steel given here.