Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added three new martial art buff events #30633

Merged
merged 3 commits into from
May 24, 2019
Merged

Added three new martial art buff events #30633

merged 3 commits into from
May 24, 2019

Conversation

Hymore246
Copy link
Contributor

Summary

SUMMARY: Content "Added support for OnMiss, OnCrit, and OnKill martial arts buff events."

Purpose of change

This change adds support for three brand new buff events to the martial arts system: OnMiss, OnCrit, and OnKill.

Describe the solution

These are implemented and work the same way as other buff events like OnHit, OnBlock, etc.
How each buff works is detailed below:

  • OnMiss - Triggers when the player misses with an attack. "Feinting" counts as a miss.
  • OnCrit - Triggers when the player scores a critical hit with an melee attack.
  • OnKill - Triggers when a player kills something with a melee attack.

For sake of demonstration, I have given Debug Mastery each of these new buffs for those who want to see them in action. Currently, no normally obtainable martial arts style has been changed to use these new buffs but they may be updated in the future to use them if need be.

Adds onmiss, oncrit and onkill buff events.
@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics Melee Melee weapons, tactics, techniques, reach attack labels May 19, 2019
Co-Authored-By: Anton Burmistrov <[email protected]>
@ZhilkinSerg ZhilkinSerg self-assigned this May 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit 8403903 into CleverRaven:master May 24, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 24, 2019
@Hymore246 Hymore246 deleted the new-martial-art-events branch May 24, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Mechanics: Character / Player Character / Player mechanics Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants