Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Plastic Bowl volume. #30493

Merged
merged 2 commits into from
May 15, 2019
Merged

Conversation

Rod995
Copy link
Contributor

@Rod995 Rod995 commented May 13, 2019

Summary

SUMMARY: Bugfixes "Fixes the inconsistent volume of the plastic bowl."

Purpose of change

Fixes the inconsistent volume of the plastic bowl!
I'm offended, really.
Water doesn't even compress, reeeee.

Describe the solution

Changes the volume of the plastic bowl.

Describe alternatives you've considered

Letting this heresy go by unmolested.

Additional context

Rod995 added 2 commits May 13, 2019 17:16
Fixes the inconsistent volume of the plastic bowl!
I'm offended, really.
Water doesn't even compress, reeeee.
@MrHrulgin
Copy link
Contributor

MrHrulgin commented May 13, 2019

EDIT: I retract my point. The plastic bowl is specifically described as "A plastic bowl with a convenient sealing lid." Assuming even when empty the lid is kept on to keep the lid and bowl together, it would be a flat .75l all the time.

I disagree with this change. While it may hold .75L of liquid, it only holds liquid when held in someone's hands. When empty, other things in a pack can fit in and around it, and so it doesn't take all of that volume. A set of bowls nested together for storage take up much less space than the total liquid carrying capacity of the stack.

It should definitely take up that space when full, but the volume of the bowl itself should stay small.

@paulenka-aleh
Copy link

paulenka-aleh commented May 13, 2019

I might be wrong, but you cannot store "plastic bowl of something" into your inventory or even a vehicle. You have to carry it or keep on the flat surface. While in inventory an empty bowl doesn't necessarily take the space "inside" it by itself. E.g. here's an example how a lot of 200ml plastic cups can take less than 200ml per cup space while empty: https://partycity6.scene7.com/is/image/PartyCity/_pdp_sq_?$_1000x1000_$&$product=PartyCity/259325

@Rod995
Copy link
Contributor Author

Rod995 commented May 13, 2019

@MrHrulgin IIRC, there's a tag for something to take up more space when it's filled. I might think about using that.
@paulenka-aleh
I'm not qualified to do volume savings like this, sadly.

@EirenexTheDragon
Copy link
Contributor

EirenexTheDragon commented May 13, 2019

Right now it also makes water bottles completly useless.
you can make plastic bowl earlier with less skills too. i think its best kept at its old value which was 0.25 liter and 0.25 volume, but we can keep the .75 version that is not craftable but can still be found outside , while also giving it 0,75 volume ofcourse.

@I-am-Erk
Copy link
Member

The intent with most bowls is that I assume you don't just shove it into your bag and let it take up 750mL of air, you take the lid off and pack stuff in and around it. I did forget to revisit the size of this when I bumped the storage up though, it should be around 500mL.

Making it take more space when full would be completely reasonable.

@EirenexTheDragon
Copy link
Contributor

The intent with most bowls is that I assume you don't just shove it into your bag and let it take up 750mL of air, you take the lid off and pack stuff in and around it. I did forget to revisit the size of this when I bumped the storage up though, it should be around 500mL.

Making it take more space when full would be completely reasonable.

like the waterskin basically? if so, i think its best it applys as full when theres just one single portion of liquid inside already, since you dont want to soak the items either

@I-am-Erk
Copy link
Member

Yeah, basically you'd assume if there's anything in it at all then the volume is 750mL and the container is closed.

@Rivet-the-Zombie Rivet-the-Zombie merged commit c4f24f9 into CleverRaven:master May 15, 2019
@Rod995 Rod995 deleted the plastic-bowl-fix branch November 3, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants