Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build: return from every_item() #30474

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix build: return from every_item() #30474

merged 1 commit into from
May 13, 2019

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented May 13, 2019

SUMMARY: None

Should fix

src/item_group.cpp: In member function 'virtual std::set<const itype*> Single_item_creator::every_item() const':
src/item_group.cpp:182:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
Makefile:768: recipe for target 'objwin/tiles/item_group.o' failed
make: *** [objwin/tiles/item_group.o] Error 1

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels May 13, 2019
@ZhilkinSerg ZhilkinSerg merged commit 0f8bf29 into CleverRaven:master May 13, 2019
@AMurkin AMurkin deleted the final-return-in-every_item branch May 13, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMurkin @ZhilkinSerg