Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct name/description for vehicle-mounted charging station #30234

Merged
merged 2 commits into from
May 4, 2019

Conversation

esotericist
Copy link
Contributor

@esotericist esotericist commented May 4, 2019

Summary

SUMMARY: Content "Correct name/description for vehicle-mounted charging station"

Purpose of change

With the advent of magazine-based batteries, which are intentionally rechargable and work in the "UPS-Compatible Recharging Station", as well as the incidental breakage of the UPS Conversion Mod, the confusion as to how to charge batteries for tools has increased. This is primarily fueled by the fact the vehicle-mounted recharging station, despite having "UPS-Compatible" in its name, has genuinely never cared about whether or not UPS was involved.

Describe the solution

Renamed the device to simply "Recharging Station", and adjusted the description for more clarity.

Also fixed some unnecessary data repetition in the Bright Nights mod, to make the changes be properly reflected when that mod is loaded.

Describe alternatives you've considered

I'm certain removing the recharging station entirely wouldn't have had any kind of social repercussions at all, and could very well be considered as a more straightforward alternative.

Additional context

Updated item name and description:
image

Updated description in the vehicle interface:
image

@esotericist
Copy link
Contributor Author

whoops. I might be lying in the description here.

@esotericist
Copy link
Contributor Author

Apparently I hallucinated the fact "tool-containing-battery-cell" would get charged in a recharging station. Updated text to better reflect actual current behavior.

@kevingranade kevingranade merged commit 95de968 into CleverRaven:master May 4, 2019
@esotericist esotericist deleted the recharge-station-text branch August 3, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants