Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for frostie_wheel #30174

Merged
merged 1 commit into from
May 3, 2019
Merged

Added recipe for frostie_wheel #30174

merged 1 commit into from
May 3, 2019

Conversation

MrHrulgin
Copy link
Contributor

The description already exists, there are items in the vehicle installation list that require it, but there's no recipe. I added the recipe, matching water demands to the highest tier of wheel and skill requirements to other gelacier-based items.

Summary

SUMMARY: Mods "Added missing recipe for gelacier wheel"

Purpose of change

Everything but the recipe was in place, but the recipe itself was missing. Without the gelacier wheel, I couldn't build a gel-based amphibious vehicle.

Describe the solution

I added the recipe, matching water demands to the highest tier of wheel and skill requirements to other gelacier-based items.

Describe alternatives you've considered

Leaving well enough alone, but this seemed like an easy enough thing to do for my first contribution. I'd never used GitHub for more than bug reports before, so I'm glad there was an easy thing to try fixing.

Additional context

None

The description already exists, there are items in the vehicle installation list that require it, but there's no recipe. I added the recipe, matching water demands to the highest tier of wheel and skill requirements to other gelacier-based items.
@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions labels May 2, 2019
@ZhilkinSerg
Copy link
Contributor

Jenkins rebuild.

"skill_used": "cooking",
"difficulty": 8,
"time": 15000,
"reversible": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reversible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true for all parts that are craftable directly from a gelatinous/oozing/gray mass, so I added it to the gelacier wheel. I confess I don't know what I does, I was just trying to keep the style consistent. Should it get a second look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's okay if similar other recipes are reversible.

@ZhilkinSerg ZhilkinSerg merged commit 525947b into CleverRaven:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants