Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust durability indications in item/part repair messages #30167

Merged
merged 1 commit into from
May 2, 2019

Conversation

esotericist
Copy link
Contributor

Summary

SUMMARY: Interface "Adjust durability indications in item/part repair messages"

Purpose of change

When repairing an item or a vehicle part, the game uses the name of the part from before the operation completed, meaning the durability indicator (both symbol and color) was for the durability state before the repair attempt.

This results in odd feedback, such as being informed that you fully repaired an object, but the name shows |\ for its durability, despite clearly having been restored to full durability.

Describe the solution

Adjusted sequencing of durability update logic such that the durability is changed before the part name is printed, so that the message log reflects the new state of the object rather than the old state of the object.

In the process of working on that, I added support for the destroyed (XX) state for items, to allow printing item names that were destroyed in the process of a repair attempt.

Since this provided functionality previously only used for vehicles, I was able to remove some vehicle-specific logic surrounding durability symbol/color.

Bonus: the message output for repairing vehicle parts now distinguishes between repairs and replacements.

Describe alternatives you've considered

I considered learning to live with misleading output, but it's simply not in my nature.

Additional context

Before and after for item repairs:
image

'Repairing' an object to destruction:
image

Before and after for vehicle repairs:
image

Message log output for a part that was fully destroyed yet not retained on the vehicle in the broken state:
image

Examples of repair-vs-replace for vehicles:
image
image

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels May 2, 2019
@tinukedaya
Copy link
Contributor

Hmm.. I do not know. The way it is now makes more sense in my opinion. Because it's the broken item you repaired. So for me it's the new way that is misleading.

Maybe reformulate the whole sentence somehow so it's more reasonable to show the resulting status of the item? Like: You repair your |\ T-shirt to || T-shirt, but better.

@esotericist
Copy link
Contributor Author

@tinukedaya Hopefully my new PR is more to your liking

@esotericist esotericist deleted the durability-messages branch August 3, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants