Fixed width calculation of translatable strings in the sidebar #30121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2019 16:17
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed width calculation of translatable strings in the sidebar"Purpose of change
string.length()used to get lengths of translatable strings made them use empty space in the sidebar.utf8_widthshould've been used on them.Describe the solution
Use
utf8_widthfor translatable strings.No changes for the sidebar view with language set to English.
Describe alternatives you've considered
None
Additional context
Translation of the wind description on the images is unrelated to this PR but shows the difference.
There is no difference in the "Thermometer - RU" because this string in Russian translation is the same as untranslated string.