Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert chemical thrower to use magazines #30118

Merged
merged 1 commit into from
May 8, 2019

Conversation

Rail-Runner
Copy link
Contributor

@Rail-Runner Rail-Runner commented Apr 30, 2019

Summary

SUMMARY: Content "Chemical thrower now has a detachable tank as a magazine"

Purpose of change

Making it possible to get chemical thrower to use tanks of different sizes. Chemical thrower's stats also got adjusted a bit, to shift part of cost, weight and price to newly-added magazine, and some other "common sense" changes to the gun itself have been made.

Describe the solution

JSON editing.

Describe alternatives you've considered

Considered replacing chemicals used as ammo with actual chemicals (hydrazine for toxic gas, and chloroform for fungicide), which would affect ammo recipes too, but this is probably better done in a separate PR.

Also considered making it use the same magazines as flamethrowers, but couldn't figure out a way to do so.

Also considered making it mountable on a vehicle to make it more convenient to be used for cleaning large fungus patches, will probably do in a later PR.

Additional context

None.

@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Items: Magazines Ammo holding items and objects. Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Apr 30, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this May 4, 2019
@ZhilkinSerg ZhilkinSerg merged commit ef530e6 into CleverRaven:master May 8, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 8, 2019
@Rail-Runner Rail-Runner deleted the chemthrower branch June 12, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants