Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npctalk: add dialogue effects to give items to NPCs #30044

Merged
merged 1 commit into from
May 1, 2019

Conversation

mlangsdorf
Copy link
Contributor

Summary

SUMMARY: Infrastructure "npctalk: add dialogue effects to give items to NPCs"

Purpose of change

Create dialogue effects that let the character give items to NPCs to hold or to use, and migrate the dialogue responses that used to implement giving items to NPCs into JSON.

This will hopefully resolve an issue reported by @A.Fulcrum where asking an NPC to train when the NPC was thirsty would be spawn the dialogue window to give the NPC something, but only under certain ill-defined circumstances.

Describe the solution

Add dialogue effects for give_npc_item and give_npc_item_to_use that allow the player to give an item to a NPC. If the NPC rejects the item, the NPC sets a reason which can be used in future dynamic lines by the NPC.

Describe alternatives you've considered

I could debug A.Fulcrum's actual issue, but that sounds difficult and tedious, while doing this means there are even more dialogue options in JSON and less in C++.

@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Apr 29, 2019
@mlangsdorf
Copy link
Contributor Author

jenkins rebuild

Create dialogue effects that let the character give items to NPCs
to hold or to use, and migrate the dialogue responses that used to
implement giving items to NPCs into JSON.
@mlangsdorf mlangsdorf force-pushed the npctalk_give_use_item branch from b602ee9 to 5d84d3a Compare April 30, 2019 11:12
@kevingranade kevingranade merged commit 4d9474f into CleverRaven:master May 1, 2019
@mlangsdorf mlangsdorf deleted the npctalk_give_use_item branch May 1, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants