Remove references to lightstrip_dead in mainlined mods
#29966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Remove references to
lightstrip_deadin mainlined modsPurpose of change
One of the changes in #29651 was the removal of
lightstrip_dead, which made since given the nature of the changes otherwise in that PR, but that ID was neither added tomigration.jsonnor was it removed from mainlined mods.Fixes #29950
Describe the solution
Removed
lightstrip_deadfrom all files which reference it in mods (replacing it withlightstrip_inactive)Added
lightstrip_deadtomigration.json(replacing withlightstrip_inactive)Describe alternatives you've considered
Could have simply re-added
lightstrip_deadbut I don't see the utility in that.