Try to fix crafting tests on mingw builds

[ifreund]

Summary

SUMMARY: None

Purpose of change

This is an attempt to debug/fix the crafting tests failing on the mingw builds for an unknown reason

Describe the solution

Add a REQUIRE for has_recipe() to see if this sheds any light on the issue.

[ifreund]

So I have no idea what's causing these tests to fail on the mingw builds. If anyone has any insight please let me know. I'll probably poke at it a bit more tomorrow.

[jbytheway]

Based on the Travis test history looks like it was caused by #29949 (but I guess you already knew that).

I took a look at those changes but don't see how they could cause this failure.

If you're able to use docker then the docker image with the toolchain set up may be useful to you in debugging this.

[ifreund]

Still don't know why these tests were failing, but adding a player::learn_recipe() call causes my local tests with a mingw build to pass. I really don't think this call should be necessary, but I couldn't figure out what was actually going on and this will patch over whatever problem is there and fix the tests.

[kevingranade]

I'm more confused as to why it isn't breaking elsewhere after that change.

[ifreund]

I'm more confused as to why it isn't breaking elsewhere after that change.

Well, the crude_picklock recipe that's being tested is a difficulty 0 autolearn recipe, so it should be available to any new player.

[kevingranade]

Hrm... do they need to proc a turn to learn it though?

[ZhilkinSerg]

I don't think any recipes are somehow learned if you didn't call learn_recipe.

[jbytheway]

But the recipe is somehow learned on non-Mingw platforms. So there's something funky here.

[ifreund]

Should be learned when the character is created, if I'm reading the relevant code correctly:

Cataclysm-DDA/src/newcharacter.cpp

Lines 557 to 563 in 8533048

	// Learn recipes
	for( const auto &e : recipe_dict ) {
	const auto &r = e.second;
	if( !knows_recipe( &r ) && has_recipe_requirements( r ) ) {
	learn_recipe( &r );
	}
	}

It looks to me like the funkiness is happening on mingw, and the code is preforming as expected for the non-mingw platforms.