Add NPC retreat, no investigate, and investigate limit zones #29867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
changed the title
mlangsdorf
added
<Enhancement / Feature>
|
I wonder if there might be more appropriate names for "no investigate" and "investigate limit". Those aren't very self explanatory. Having it in the dialogue tutorial does help |
|
I am open to suggestions for better names. They make sense to me and all zone names are kind of cryptic, honestly. |
|
Yeah, I'm struggling to think of anything better at the moment too. If it comes to mind I'll let you know |
|
No investigate zone - how about "ignore sounds" zone? Investigate limits - I think this one is probably okay if 'no investigate' is changed since it makes them less similar sounding. However I sort of vaguely think "investigation limits" sounds a little clearer in intent. |
Make both of these functions take an int range argument that defaults to MAX_DISTANCE.
Add a new zone that friendly NPCs will prefer to retreat to, instead of fleeing in a blind panic. Update the NPC dialogue tutorial.
Add two new zones: one prevents friendly NPCs from investigating noises coming from it, the other prevents friendly NPCs from investigating noises coming out of it.
mlangsdorf
force-pushed
the
npc_control_zones
branch
from
c8fa040 to
adf3dbb
Compare
|
"Don't investigate" "Investigate within reason/limits" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Add NPC retreat, no investigate, and investigate limit zones"Purpose of change
Part of #29333
Add 3 new zones for friendly NPCs:
Describe the solution
Add two new functions to the zone manager: get_nearest returns the nearest point of a zone type within a specified distance, and has_defined returns true if there is a cached zone type.
In npcmove.cpp, good_escape_dir will attempt to path to the nearest retreat zone in preference to using the threat map.
in npctalk.cpp, handle_sounds will skip investigating sounds that come from inside a no investigate zone, or if a investigate limit zone is defined, from sounds coming from outside of it.
Update the in-dialogue tutorial to include the new features.