Fix liquid consumption in crafting #29532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- count_by_charges contents were getting skipped - this caused consumption of liquids in containers to fail
ifreund
added
Crafting / Construction / Recipes
|
This also fixed liquid consumption when using a washboard, FYI :) |
|
Cool. Yeah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary: Bugfixes "Fix liquid consumption in crafting."Purpose of change
Fixes #29525
Describe the solution
Because of some poor code I wrote a long time ago, this bug popped up as an indirect result of my changes in #29309. This makes sure that container contents are properly filtered and consumed with
use_charges().Describe alternatives you've considered
Letting everyone continue to enjoy infinite liquids for a little longer.