Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature for water from vehicle taps #29489

Merged
merged 6 commits into from
Apr 13, 2019

Conversation

Hirmuolio
Copy link
Contributor

@Hirmuolio Hirmuolio commented Apr 12, 2019

Summary

SUMMARY: Bugfixes "Set water from vehicle kitchen to same temperature as it was in tank"

Purpose of change

Fixes #29457

The water you get from vehicle kitchen has no defined temperature. Usually it would immediately be set to enviroment temperature but not always.

Describe the solution

Get the total energy in the liquids in tanks and divide by their total mass to geth the specific energy in tank liquids. Then set the liquid that the player gets to this specific energy.

Describe alternatives you've considered

Averaging temperatures is enother option. But the water in tanks can be partially frozen at 0 C and the liquid player gets would be fully unforzen at 0 C.

Additional context

It should work but I don't have time to do much testing.

@Hirmuolio Hirmuolio changed the title Hirmuolio vehicle tap Fix temperature for water from vehicle taps Apr 12, 2019
@Hirmuolio Hirmuolio changed the title Fix temperature for water from vehicle taps [WIP] Fix temperature for water from vehicle taps Apr 12, 2019
@Hirmuolio Hirmuolio changed the title [WIP] Fix temperature for water from vehicle taps Fix temperature for water from vehicle taps Apr 12, 2019
@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` labels Apr 12, 2019
@kevingranade kevingranade merged commit 16bc941 into CleverRaven:master Apr 13, 2019
@Hirmuolio Hirmuolio deleted the Hirmuolio-vehicle-tap branch April 13, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Temperature Freezing, cooling, thawing, heating, etc. mechanics Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
3 participants