Fix #29472 - nullptr while trying to find a NPC in the overmap #29487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix #29472 - nullptr while trying to find a NCP in the overmap"
Purpose of change
Fix #29472 - nullptr while trying to find a NCP in the overmap
There were multiple missing checks on
find_npc
method which might returnnullptr
if the NCP can't be found in the overmap.Describe the solution
Add a simple check for
nullptr
. Add some debug msgs in missions to better diagnose the missing NPC problem.Describe alternatives you've considered
There are probably no simpler alternatives.
Additional context
N/A.