Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify HELMET_COMPAT flag to allow proper use of some headgear. #29475

Merged

Conversation

zombiethoughts
Copy link
Contributor

@zombiethoughts zombiethoughts commented Apr 11, 2019

Summary

SUMMARY: Bugfixes "modifies HELMET_COMPAT flag to allow use of headgear up to 40 encumbrance"

Purpose of change

Some types of headgear were not allowed to be worn because of HELMET_COMPAT flag being lower than certain headgears encumbrance value.

Mentioned in #29171

Describe the solution

Modified the combined value of current head encumbrance plus encumbrance of item trying to be worn from a maximum of 20 to a maximum of 40.

@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics Items / Item Actions / Item Qualities Items and how they work and interact labels Apr 12, 2019
@zombiethoughts
Copy link
Contributor Author

This should pass gorgon now. My fingers were being dumb earlier, and I had to fix the summary line multiple times.

@anothersimulacrum
Copy link
Member

Jenkins rebuild

@kevingranade
Copy link
Member

I really want to enumerate a bunch of the examples that get thrown around about what should and shouldn't fit, and stick em in a test.

@zombiethoughts
Copy link
Contributor Author

Cool, should I just leave this here, or should we close this since you're working on it?

@Photoloss
Copy link
Contributor

I really want to enumerate a bunch of the examples that get thrown around about what should and shouldn't fit, and stick em in a test.

No idea how many beanie hats you might be able to stretch over your head but the main one would be to fit a skullcap or a tight cloth cap, a mail coif or sleek open-faced helmet and a greathelm on your head in that order, and not suffer stamina loss or similar strain from just walking around. This combination does not need to be viable for prolonged combat however and should in fact drain your stamina pretty quickly if running/fighting during the summer so the great helm should maintain high mouth encumbrance.

I believe most other cases of heavily loaded heads are already covered by the mouth+eyes split and the "strapped" layer and at best need material/flag fixes (e.g. the army helmet is VARSIZE but contains no cotton or leather to represent an adjustable liner). In terms of what shouldn't fit: stacking pretty much any two hard-shell helmets unless one of them is the great helm (or the aforementioned NYI skullcap), wearing "bulky"/rimmed hats or uniform-style caps/berets underneath hard helmets and wearing more than maybe 2-3 of those hats piled on top of one another (you could make a pile of hats but they would no longer cover your actual head at that point, a tight fedora under a large sombrero should be doable). No idea how to handle hoods as a purpose-built one would certainly fit a hardhat or spangenhelm but definitely not the sombrero.

@ZhilkinSerg ZhilkinSerg self-assigned this May 4, 2019
@ZhilkinSerg ZhilkinSerg merged commit 138ba4d into CleverRaven:master May 8, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants