Make Clang/Tiles/Cmake build a release build #29470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
added
Code: Performance
This was referenced Apr 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Work around the persistent test failure where the Clang/Tiles build is taking too long to execute the starvation test.
Describe the solution
Unlike any other build, this one builds as debug, it may be taking orders of magnitude longer to execute because of std container handling.
Describe alternatives you've considered
The test also needs to be profiled and optimized, it is taking a very long time to execute in general, but I don't think there's any value to having this be a debug build.
Additional context
See https://travis-ci.org/CleverRaven/Cataclysm-DDA/jobs/518809722 for an example failure.
I determined it's the starvation test that is failing by examining a non-failing test run and seeing what comes after "shadowcasting_float_quad_equivalence".