Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vehicle parts and vehicles for Aftershock #29390

Merged
merged 7 commits into from
Apr 14, 2019
Merged

New vehicle parts and vehicles for Aftershock #29390

merged 7 commits into from
Apr 14, 2019

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Apr 8, 2019

Summary

SUMMARY: Mods "Added the control station and hauling space to various vehicles in Aftershock, as well as the new tanker trucks and mounted tank parts."

Purpose of change

After playtesting much larger cargo spaces, I found them much more enjoyable to use, but I think changing the existing balance of the cargo space wouldn't go over that well. Control stations are mainly for compactness.

Describe the solution

  • Added the control station to APCs. It combines the functionality of controls, a clock, remote controls, and a camera control station.
  • Replaced Truck Trailers' cargo spaces with hauling spaces that can hold up to 1500 L of items.

The control station can't be crafted; you'll have to pull it off an existing APC. The hauling space can be crafted, using three heavy duty frames, four sheet metal, a welding torch, and some tools.

  • Added roof-mounted external tanks and mounted external tanks; one goes on the roof, the other goes on a frame. Both hold 200 L. Two new vehicles use the mounted external tanks, the gas tanker and the water tanker.

Describe alternatives you've considered

Like I mentioned in the purpose, I considered changing existing cargo spaces, but cargo spaces right now are used to represent flatbeds, truck trailers, and pickups, among other things. It was simpler to replace the truck trailer's when I used that for my math.

Additional context

Hauling space capacity is based off of dimensions from this site: http://yrc.com/trailer-dimensions/

The smallest trailer on that site (28 foot high cube trailer) has a cubic capacity of 2029 cft, which converts to 57454.88 liters. A truck trailer has 32 spaces for cargo, so if you divide that number by 32, you get 1795.465 L of space per tile, which I rounded down to 1500 L so we can at least pretend it's balanced.

@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions labels Apr 8, 2019
@@ -161,6 +176,41 @@
{ "item": "press", "charges": 0, "prob": 50 }
]
},
{
"type": "vehicle_part",
"id": "afs_control_station",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with seeing this in mainline and expanded to a couple of other military vehicles.

I'd also like a version of this without REMOTE_CONTROLS - call it an integrated control console - added to all the military vehicles in Tanks, if that's something you would be interested in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can put it in mainline, but I'd also open it as a different PR so as not to muddy the waters. I've never actually played using Tanks, but I don't think it should be too much of a stretch to put it in.

@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 9, 2019

I ended up expanding it a little more. I added roof-mounted tanks and mounted tanks, and added them to two new vehicles, the gas tanker and the water tanker. Like truck trailers, they don't actually have any controls of their own, but lug around a huge amount of liquid.

I don't believe that tanker trucks existing in mainline would be realistically outlandish, but the sheer amount of gas you can get from one might break balance, so I held off.

@Ilysen Ilysen changed the title Two new vehicle parts for Aftershock New vehicle parts and vehicles for Aftershock Apr 9, 2019
@kevingranade
Copy link
Member

json-style please.

@kevingranade kevingranade merged commit 3ef243b into CleverRaven:master Apr 14, 2019
@Ilysen Ilysen deleted the AFSVehicles branch April 14, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants