Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased time to craft and components needed for steel frame and heavy duty frame #29327

Merged
merged 4 commits into from
Apr 6, 2019
Merged

Increased time to craft and components needed for steel frame and heavy duty frame #29327

merged 4 commits into from
Apr 6, 2019

Conversation

Night-Pryanik
Copy link
Contributor

@Night-Pryanik Night-Pryanik commented Apr 6, 2019

Summary

SUMMARY: Bugfixes "Increased time to craft and components needed for steel frame and heavy duty frame."

Purpose of change

Time required to craft steel frame and heavy duty frame was equal (8 minutes) despite requiring different amounts of steel lumps (10 versus 18). I'm neither a welder nor a blacksmith, but I think that 8 minutes is just insufficient to first cast and then weld 18 hefty steel lumps into one frame. Pinging @Rivet-the-Zombie for clarification.

Describe the solution

Increased time to craft steel frame from 8 to 45 minutes, and heavy duty frame from 8 to 90 minutes.
Also increased components needed to craft steel frame from 10 to 20, and heavy duty frame from 18 to 100.

@Night-Pryanik Night-Pryanik added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 6, 2019
@SirPendrak
Copy link
Contributor

This might be a good moment to addjust ammount of steel needed. Mass of product should equal mass of components it this case.

@Night-Pryanik
Copy link
Contributor Author

This might be a good moment to addjust ammount of steel needed. Mass of product should equal mass of components it this case.

Yeah, heavy duty frame weights 100 kilograms, while crafting it requires only 18 lumps of steel weighting 1 kg each, resulting in gaining of ~80 kg out of nowhere after successful craft.

@Night-Pryanik Night-Pryanik changed the title Increased time to craft frame and heavy duty frame Increased time to craft and components needed for steel frame and heavy duty frame Apr 6, 2019
@ZhilkinSerg ZhilkinSerg merged commit f1359ac into CleverRaven:master Apr 6, 2019
@kevingranade
Copy link
Member

This might overshoot a bit now that I notice one section of frame is 100kg, that seems high.

Some quick napkin math though...
https://en.wikipedia.org/wiki/List_of_truck_types#Medium_trucks
Says medium trucks range from 6,300 - 11,700 of, assuming the low end of that is a 5x8 tile truck, that comes to about 150kg per tile, so nevermind, that's pretty close.

@Night-Pryanik Night-Pryanik deleted the vehicle-frames-time-to-craft-fix branch April 6, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants