Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainline Filthy Clothes mod #29291

Merged
merged 8 commits into from
Apr 6, 2019
Merged

Mainline Filthy Clothes mod #29291

merged 8 commits into from
Apr 6, 2019

Conversation

Night-Pryanik
Copy link
Contributor

@Night-Pryanik Night-Pryanik commented Apr 5, 2019

Summary

SUMMARY: Mods "Mainline Filthy Clothes mod."

Purpose of change

Closes #26228.
Discussion in #26228 revealed that filthy clothing mechanics is working rather reasonably and is ready to be mainlined.

Describe the solution

Added a new FILTHY_CLOTHES external option which is responsible for the whole functioning of filthy clothing mechanics. Default is true.
Changed FILTHY_MORALE and FILTHY_WOUNDS defaults to true.
Added a new No Filthy Clothes mod with all three options set to false.
Obsoleted Filthy Clothes mod.
Removed Filthy Clothes mod from the default mods list.

@Night-Pryanik Night-Pryanik added Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` labels Apr 5, 2019
@ZhilkinSerg
Copy link
Contributor

I am afraid that this change will disable filthy clothing for those who enabled it previously. It would be better to obsolete existing "Filthy Clothing" mod and make new "No Filthy Clothing" (with new id).

@Treah
Copy link
Contributor

Treah commented Apr 5, 2019

I agree with ZhilkinSerg here as changes tend to get lost in the ether and also if you intend to put that warning on the mod then you would have to literally leave it there forever. As he said it makes much more sense to make a new mod with a new ID and just remove the old one. This solves the problem of not having to keep a warning around that will soon not be needed on the off chance some one comes back after a year of not playing.

@kevingranade
Copy link
Member

Agreed with above feedback, the reason it's "no filthy clothes" and included by default is precisely so it wouldn't break saves.
You can migrate it away by adding a "no filthy" mod, flipping all the option defaults to enable filthy clothing features, and obsoleting the filthy clothing mod. Since it's a no-op, you don't have to keep the contents of the mod around, just add it to the mod migration list.

@Night-Pryanik
Copy link
Contributor Author

Ok, will do.

@ZhilkinSerg ZhilkinSerg self-assigned this Apr 6, 2019
@ZhilkinSerg ZhilkinSerg merged commit dd40cb0 into CleverRaven:master Apr 6, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Apr 6, 2019
@Night-Pryanik Night-Pryanik deleted the mainline-filthy-clothes-mod branch April 6, 2019 08:05
@Feuerhai Feuerhai mentioned this pull request Apr 7, 2019
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants