-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainline Filthy Clothes mod #29291
Mainline Filthy Clothes mod #29291
Conversation
Added a check for this option when monsters with FILTHY flag is dropping loot
Changed the description. Made FILTHY_CLOTHES, FILTHY_MORALE and FILTHY_WOUNDS false in the mod.
I am afraid that this change will disable filthy clothing for those who enabled it previously. It would be better to obsolete existing "Filthy Clothing" mod and make new "No Filthy Clothing" (with new id). |
I agree with ZhilkinSerg here as changes tend to get lost in the ether and also if you intend to put that warning on the mod then you would have to literally leave it there forever. As he said it makes much more sense to make a new mod with a new ID and just remove the old one. This solves the problem of not having to keep a warning around that will soon not be needed on the off chance some one comes back after a year of not playing. |
Agreed with above feedback, the reason it's "no filthy clothes" and included by default is precisely so it wouldn't break saves. |
Ok, will do. |
Summary
SUMMARY: Mods "Mainline Filthy Clothes mod."
Purpose of change
Closes #26228.
Discussion in #26228 revealed that filthy clothing mechanics is working rather reasonably and is ready to be mainlined.
Describe the solution
Added a new
FILTHY_CLOTHES
external option which is responsible for the whole functioning of filthy clothing mechanics. Default is true.Changed
FILTHY_MORALE
andFILTHY_WOUNDS
defaults to true.Added a new
No Filthy Clothes
mod with all three options set to false.Obsoleted
Filthy Clothes
mod.Removed
Filthy Clothes
mod from the default mods list.