Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for more handle materials in crafting of some tools #27739

Merged
merged 5 commits into from
Jan 22, 2019

Conversation

ACCount12
Copy link
Contributor

Summary

SUMMARY: Balance "Allows for more handle materials in crafting of some tools"

Purpose of change

Some tool crafting recipes depend on plastic, and there isn't really a good reason for that. This PR allows more tools to use wooden or metallic handles, which was a very common practice IRL before plastic gained traction in the industry.

@cainiaowu
Copy link
Contributor

you should probably make them a "requirement" group and use that.

@ACCount12
Copy link
Contributor Author

Too many handle types for that I think. I also have a Travis issue I don't know how to deal with, would have to check that one later.

@ZhilkinSerg ZhilkinSerg added Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Jan 22, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Jan 22, 2019
@ACCount12
Copy link
Contributor Author

ACCount12 commented Jan 22, 2019

Still no idea on what trips the JSON check. The message is extremely unhelpful.

@ZhilkinSerg ZhilkinSerg merged commit 837627a into CleverRaven:master Jan 22, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jan 22, 2019
@ACCount12 ACCount12 deleted the patch-1 branch January 23, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants