Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for magazine ammo type mismatch. #27736

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Fixes #27730
As the ammo type got shifted around, the magazine/ammunition type agreement in the leadworks feed adapter went out of sync.

Describe the solution

Makes the ammo type agree again.

Describe alternatives you've considered

Removing the feed adapter isn't a completely unreasonable option, I'm pretty sure it applies to way more guns than it should.

Additional context

I haven't tested this other than confirming that the warning disappeared, need to verify that you can install and use the adapter before merging this.

@tenmillimaster
Copy link
Member

Can we just delete the 460 entries until a more suitable workaround can be made? It's a bit pointless to have a 460 conversion when the only gun that uses it already uses the magazine for the conversion.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 22, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Jan 22, 2019
@ZhilkinSerg ZhilkinSerg merged commit 28eb762 into CleverRaven:master Jan 22, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jan 22, 2019
@kevingranade kevingranade deleted the 460-magazine-mag-fix branch February 17, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants