Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Flag : HIDE_PLACE #27620

Merged
merged 16 commits into from
Jan 22, 2019
Merged

New Flag : HIDE_PLACE #27620

merged 16 commits into from
Jan 22, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Jan 14, 2019

Summary

SUMMARY: Content "Adds new flag HIDE_PLACE"

Purpose of change

Some furniture and terrain should be able to hide creature from sight

Describe the solution

Add a new flag for furniture and terrain called HIDE_PLACE and edit creature::sees to check for that flag.
Now a creature on a tile with that flag can only be seen by a creature on an adjacent tile.

Describe alternatives you've considered

Additional context

I've added the flag to pillow fort, improvised shelter and dumpster. I had to change move cost of dumpster to make it walkable.
I could also add it to dresser and locker but like dumpster it'd need a change of move cost so I'm not sure. I'd like feedback on that.

I'd also like to make it so when a creature is on the tile it can only see adjacent tiles, but I haven't found a clean way to do it. Is there a way to add an effect when the creature is on the tile ? -> Will go in another flag.

@SirPendrak
Copy link
Contributor

Creature in a tile seeing only adjecent tiles should be a new, separate flag, so there is a posibility for sneaking through tall grass whlile still observing zeds.

@Fris0uman
Copy link
Contributor Author

Allowing Tall grass to hide you might be OP, currently HIDE_PLACE makes you invisible not matter your skills or your size.
Making it so that HIDE_PLACE also hinder your sight is a way to balance it out, for exemple you could still use it to "sneak" but you'd need to regularly peek out of your hiding place to see were you're going, it would make it a bit more involved thant just walking from hiding tile to hiding tiles

@nexusmrsep
Copy link
Contributor

This is fulfilling the 'hunting blinds' idea of the 'hunting' project.

@Fris0uman
Copy link
Contributor Author

Well in this case I guess the sight aspect might indeed be best in another flag.
Then I guess I just need to add the flag to more furniture/terrain

@Fris0uman Fris0uman changed the title [CR] [WIP] New Flage : HIDE_PLACE [CR] New Flage : HIDE_PLACE Jan 14, 2019
@Night-Pryanik Night-Pryanik changed the title [CR] New Flage : HIDE_PLACE [CR] New Flag : HIDE_PLACE Jan 14, 2019
Co-Authored-By: Fris0uman <[email protected]>
@Night-Pryanik
Copy link
Contributor

Jenkins rebuild

@ZhilkinSerg ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Jan 15, 2019
@Fris0uman
Copy link
Contributor Author

Travis seems to find and error with furniture.json but I can't see what it is. As far as I can tell it's formatted correctly.

@Night-Pryanik
Copy link
Contributor

No, the problem is with creature.cpp. Please astyle your changes.

@Fris0uman
Copy link
Contributor Author

I tried astyling it using VS astyle extension and the options from CODE_STYLE.md but it's still failing.

@Fris0uman Fris0uman changed the title [CR] New Flag : HIDE_PLACE New Flag : HIDE_PLACE Jan 19, 2019
@Fris0uman Fris0uman mentioned this pull request Jan 19, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Jan 22, 2019
@ZhilkinSerg ZhilkinSerg merged commit e4cfba7 into CleverRaven:master Jan 22, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jan 22, 2019
@Fris0uman Fris0uman deleted the Hide_Flag branch March 21, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants