Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimizations related to coordinates (2018-12-15) #27109

Merged
merged 5 commits into from
Dec 16, 2018

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Code optimizations related to coordinates"

Purpose of change

Cleanup code related to coordinates.

Describe the solution

See commit messages.

- renamed field in city struct for clarity (s -> size);
- added point instead of int coordinates in city struct (x,y -> pos).
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Dec 14, 2018
@kevingranade
Copy link
Member

Need to update some test code as well.

src/overmap.cpp Outdated Show resolved Hide resolved
tests/savegame_test.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 2eecee8 into CleverRaven:master Dec 16, 2018
@ZhilkinSerg ZhilkinSerg deleted the coord-optimizations branch December 17, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants