Adds expertise traits for NPCs #27095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expertise traits represent skills that can only be learned through training, not through books and DIY. These are largely upper education skills such as engineering and medicine, but also includes professional skills learned over a lifetime. At first these will be used alongside NPC "job histories" just to tell stories, but in the future they will be start points for missions and more.
mlangsdorf
approved these changes
Dec 14, 2018
mlangsdorf
added
<Enhancement / Feature>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds expertise traits for NPCs (not yet attached to NPC classes)"Purpose of change
Expertise traits represent skills that can only be learned through training, not through books and DIY. These are largely upper education skills such as engineering and medicine, but also includes professional skills learned over a lifetime.
At first these will be used alongside NPC "job histories" just to tell stories, but in the future they will be start points for missions and more.
Describe the solution
Like background traits, expertise is currently best implemented through mutations, as these are a mostly permanent way of tracking things like this and can be used conditionally in dialogue very easily, and already have existing sorting mechanisms to make sure the right npcs spawn with the right traits. We should probably consider making it possible to hide traits at some point.
Describe alternatives you've considered
Extensive discussion in discord on the number and types of expertises is still underway.
I think the ones I have posted are pretty much settled in.
I have not yet applied the expertises under discussion such as the various types of engineering.
Additional context
Trait groups and class connection will be done in a separate PR for easier reviewing.