missions: autoset monster_kill_goal for KILL_TYPE and KILL_SPEC #27050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
<Enhancement / Feature>
BevapDin
reviewed
Dec 10, 2018
Add monster_type as a JSON parameter, and then automatically set the kill goal for MGOAL_KILL_MONSTER_TYPE and MGOAL_KILL_MONSTER_SPEC instead of requiring a start function to do it.
mlangsdorf
force-pushed
the
missionstart_autokill
branch
from
e168645 to
2e56ad6
Compare
|
@mlangsdorf thanks for constantly improving my amateurish coding. Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "missions: autoset monster_kill_goal for KILL_TYPE and KILL_SPEC"Purpose of change
Make it easier to add new missions in JSON, by allowing MGOAL_KILL_MONSTER_TYPE and MGOAL_KILL_MONSTER_SPEC missions to be set up almost entirely in JSON.
Describe the solution
Add monster_type as a JSON parameter, and then automatically set the kill goal for MGOAL_KILL_MONSTER_TYPE and MGOAL_KILL_MONSTER_SPEC instead of requiring a start function to do it.
Describe alternatives you've considered
This is really straightforward.
Additional context
This is a small part of a general effort to move more of mission definitions into JSON - see #26794