Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Searching from Favorites Tab #26842

Merged
merged 2 commits into from
Nov 25, 2018

Conversation

LetterShapedGlyphs
Copy link
Contributor

@LetterShapedGlyphs LetterShapedGlyphs commented Nov 25, 2018

Summary

SUMMARY: Interface "Enables recipe search from Favorites/Recent tab"

Purpose of change

Fixes #26826 (Recipe search functionality was disabled when the Favorites/Recent tab was focused.)

Describe the solution

Re-ordered the if/else statements to allow the filter string to take priority again.

Describe alternatives you've considered

N/A

Additional context

The files change looks pretty complicated considering all I did was re-order it but oh well.
Edit: That's what I get for being in a hurry and not Astyling

@ZhilkinSerg ZhilkinSerg added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Nov 25, 2018
@OzoneH3 OzoneH3 merged commit d32485d into CleverRaven:master Nov 25, 2018
@LetterShapedGlyphs LetterShapedGlyphs deleted the CraftingSearch branch October 14, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants