Split up options_manager::init #26833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This thousand-line function is big enough that gcc 7 chokes on it and gives a nearly-warning message: src/options.cpp:874:6: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without The message causes Vim to open that file every time I compile it, which is a little annoying. Resolve by splitting it up into more manageable chunks. No functional change.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This thousand-line function is big enough that gcc 7 chokes on it and gives a nearly-warning message:
The message causes Vim to open that file every time I compile it, which is a little annoying.
Describe the solution
Resolve by splitting it up into more manageable chunks.
No functional change; purely rearranging code.
Additional context
I suspect that such a large function might also cause some static analysis tools to run very slowly.
I see in the Travis CI output that gcc 8 chokes on a couple of different functions in a similar way, but I'll let gcc 8 users worry about those.