vehicles: align turn directions in increments of 15 degrees #26671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
Vehicles
mlangsdorf
force-pushed
the
vehicle_turns
branch
from
26e9889 to
7427a14
Compare
BevapDin
reviewed
Nov 14, 2018
Force turn directions to be smoothed into 15 degree increments.
mlangsdorf
force-pushed
the
vehicle_turns
branch
from
7427a14 to
1ced94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "vehicles: align turn directions in increments of 15 degrees"Purpose of change
Fixes #26549
Smooth a vehicle's turn direction to be in increments of 15 degrees.
Describe the solution
When updating a vehicle's turn direction, return an canonical turn direction that is the rounded direction in increments of 15 degrees.
Facing should eventually align with turn direction as the vehicle moves.
Describe alternatives you've considered
Storing the actual turn direction in increments of 1 degree but smooth it out for all uses is more complicated without making things better.