Translate item category names on the fly #26656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Documentation>
BevapDin
reviewed
Nov 13, 2018
src/item_category.cpp
Outdated
| } | ||
| return id_ < rhs.id_; | ||
| } | ||
|
|
||
| bool item_category::operator==( const item_category &rhs ) const | ||
| { | ||
| return sort_rank_ == rhs.sort_rank_ && name_ == rhs.name_ && id_ == rhs.id_; | ||
| return sort_rank_ == rhs.sort_rank_ && name() == rhs.name() && id_ == rhs.id_; |
There was a problem hiding this comment.
Would be nice to have this comparison logic (as well as the relational operator as used above) as part of the translation class, so one does not have to update each piece of code that is converted to use this type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix item category names not updated when switching the language"Purpose of change
Translate item category names on the fly so they're correctly updated when switching the language.
Describe the solution
Store a translation object instead of a translated string in
item_category. The inventory UI is using pseudo categories with composed names to represent item locations, which need no further translation, so these categories are constructed withno_translation().Also updated
JSON_INFO.md.Additional context
Should really remove the pseudo category hack and replace it with some proper wrapper, but that's out of the scope of this PR.