Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make funnels collect water automatically. #2618

Merged
merged 4 commits into from
Aug 24, 2013

Conversation

gmcnew
Copy link
Contributor

@gmcnew gmcnew commented Aug 23, 2013

With this change, to collect rainwater, you activate a funnel and then drop a water-tight, sealable container onto its tile. Then you wait. The funnel will try to add rainwater to a container on its tile. (If multiple containers are present, it uses the largest one which is (1) water-tight and sealable and (2) doesn't contain a liquid other than water or acid.)

Dropping multiple containers on a tile won't help you, because the funnel won't switch automatically.

If a funnel is exposed to rain as well as acid rain before the container is collected, the liquid in the container may change to "weak acid water". This means you should try to pick up a water container very soon after it becomes full. (If water is exposed to acid rain and doesn't turn into weak acid water, it may become more poisoned instead, but boiling takes care of that.)

A funnel should collect around 14 charges of water per hour when it's raining, or 7 or so charges per hour during a drizzle. A makeshift funnel is easy to craft but is much smaller than a regular funnel and only collects 1% as much water.

@CataJenkins
Copy link

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/552/

@KA101
Copy link
Contributor

KA101 commented Aug 23, 2013

Dunno about this one. More realistic, sure, but also more tedious. Seems like we'd have to manually wait around for the bottles to fill.

Perhaps keep the current funnel-activation, but make it take time instead, with an abort prompt for weather change?

@kevingranade
Copy link
Member

The current function was only a stopgap until someone got around to
implementing this version. You don't generally wait around, you go do
something else, like craft, sleep, or read.

A later update will allow you to leave the area and still have them fill.

@ianestrachan
Copy link
Contributor

This is actually how I tried to use funnels the first time I found them, and makes much more sense, so I'm glad to see it.

Put down a funnel and a steel jerrycan and you're all set... as long as it doesn't turn into acid rain.

@kevingranade
Copy link
Member

Along with some very nice trap handling cleanups, thank you!

@CataJenkins
Copy link

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/577/

@gmcnew
Copy link
Contributor Author

gmcnew commented Aug 23, 2013

Okay, I think this is good to go. =) (I didn't use the [WIP] tag because I thought it was pull-ready from the beginning.)

@CataJenkins
Copy link

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/578/

@kevingranade kevingranade merged commit 01e1e41 into CleverRaven:master Aug 24, 2013
@gmcnew gmcnew deleted the funnels branch August 24, 2013 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants