Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steel_lump volume #25032

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Fix steel_lump volume #25032

merged 1 commit into from
Aug 21, 2018

Conversation

cake-pie
Copy link
Contributor

@cake-pie cake-pie commented Aug 21, 2018

Summary

SUMMARY: Content "fix steel_lump volume"

Purpose of change

Bring stats of "lump of steel" steel_lump in line with "chunk of steel" and "scrap metal".

Thanks to helpful comments in metals.json showing the math, it is clear that there was a mistake in the volume for steel_lump.

    "id": "scrap",
    "name": "scrap metal",
    "weight": 50,
    "volume": 1,
    "count": 2,
    "stack_size": 10, "//": "Density 7.60g/cm³ ~ 1.9kg/250ml @ 50g/unit ~ stack 40 but fragments stacks poorly so only 25% of this",

In-game, scrap metal (10) is 500g/250ml which is approx 25% as heavy as the quoted 1.9kg/250ml of a solid block of steel.

    "id": "steel_chunk",
    "name": "chunk of steel",
    "weight": 250,
    "volume": 1,
    "stack_size": 4, "//": "Density 7.60g/cm³ ~ 1.9kg/250ml @ 250g/unit ~ stack 8 but mishapen so only 50% of this",

In-game, chunk of steel (4) is 1kg/250ml which is approx 50% as heavy as the quoted 1.9kg/250ml of a solid block of steel.

    "id": "steel_lump",
    "name": "lump of steel",
    "weight": 1000,
    "volume": 2,
    "stack_size": 2, "//": "Density 7.60g/cm³ ~ 1.9kg/250ml @ 1000g/unit ~ stack 2 and formed as a solid ingot so 100% of this",

In-game, lump of steel (1) is 1kg/250ml which is not the expected 100% density given by the comment.

Describe the solution

Change the volume of "lump of steel" steel_lump in /items/resources/metals.json
"volume": 2,
"volume": 1,
This gives lump of steel (2) at 2kg/250ml which is what we'd expect.

@kevingranade kevingranade merged commit b54b781 into CleverRaven:master Aug 21, 2018
@cake-pie cake-pie deleted the metal/steel branch August 21, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants