Optional worldmod to disable lifting requirements (strength and lifting quality) #24053

Wad67 · 2018-06-19T15:36:21Z

This is a small, optional 're-balance' mod that simply bypasses the checks for lifting quality and strength when adding or removing vehicle parts.

Adds DISABLE_LIFTING world option, mod and relevant 'overrides' to can_install_part() and can_remove_part( ).

Updating tined eating instrument

The right way round

Could not figure out how to include the world mod without alterting .gitignore Unable to ignore .gitignore so ¯\_(ツ)_/¯ Adds DISABLE_LIFTING world option, mod and relevant 'overrides' to can_install_part() and can_remove_part( ).

Had to remove 'mods/' temporarily.

Fixed up the two if statements that were a bit squashed. Thanks Fuji

…ysm-DDA into DisableRequirements

Night-Pryanik · 2018-06-19T16:00:42Z

src/veh_interact.cpp

@@ -605,6 +605,10 @@ bool veh_interact::can_install_part() {
        str = base.lift_strength();
        use_aid = max_lift >= lvl;
        use_str = g->u.can_lift( base );
+        if( get_option<bool>( "DISABLE_LIFTING" ) ) {


This check should be done earlier. I.e. if this option is active, there's no need to calculate use_aid and use_str at all.

Okay, I'll see what I can do.

Night-Pryanik · 2018-06-19T16:05:03Z

Please do tell me: when even a wimp has an ability to lift heavy vehicle parts with their bare hands, this adds something incredibly fun or interesting to the game?

Wad67 · 2018-06-19T16:32:51Z

Not entirely sure what you are asking.
The purpose of this mod is to optionally remove something that people aren't interested in dealing with.
Similar to prevent zombie revivification and simplified nutrition, it is an optional revert of a feature #16280

Note that the UI still requires values for qual, lvl and str. I don't intend to alter the UI so that these are not required. But if absolutely required I will attempt to do so.

NickGrease · 2018-06-19T17:17:34Z

Just a little nit-pic, this doesn't really revert. It removes. I'd be happy with reverting back to JACK, or calling the PR what it really is. The same way Simplified Nutrition doesn't remove eating.

Wad67 · 2018-06-19T17:19:15Z

Apologies, I wasn't aware that jacking was a requirement for parts before lifting.

Unless you are referring to the jacking quality required for tires, which is left untouched.

NickGrease · 2018-06-19T17:24:57Z

I could be totally wrong, but I think engines at least had a JACK quality. Also, I'm pretty sure most everything had a strength check, which this seems to be removing. If, I'm wrong my apologies.

Wad67 · 2018-06-19T17:30:12Z

Yes, the strength check is removed also as I consider it to be a 'lifting' requirement. Note that this only effects part removals and installations.
If I just disabled lifting, it would still be restricted by strength(even more so by the absence of lifting equipment).

DoctorGoat · 2018-06-19T17:47:51Z

I'm in favor of things like this. It's good to be able to customize your game, and a customization like this won't cause problems for maintenance due to its simplicity.

NickGrease · 2018-06-19T18:13:05Z

Since this is an Option i'm not to concerned, just wanted to point out this is a removal (of Strength), and would like to see that in the PR title if only for clarity. Future searches are easier with well labeled PR's.

ghost · 2018-06-19T20:27:31Z

Agreed that this is a good thing. People come to Cata for different things - some praise its realism, and some praise the crazy stuff and gameplay. Allowing both parties to enjoy the game more fully is, in my eyes, a good thing no matter how you view it.

Leland · 2018-06-19T21:51:19Z

Any interest in signing as the author and maintainer of the mod?

Wad67 · 2018-06-20T00:19:00Z

Sure, don't know where I would do that though.

DracoGriffin · 2018-06-20T00:24:04Z

Just add a line in here (generally under "name") with "authors":

  {
    "type": "MOD_INFO",
    "ident": "disable_lifting",
    "name": "No Lifting Reqs",
    "description": "Strength checks and lifting qualities are no longer required for installing or removing vehicle parts.",
    "category": "rebalance",
    "dependencies": [ "dda" ]
  },

Example:

  {
    "type": "MOD_INFO",
    "ident": "disable_lifting",
    "name": "No Lifting Reqs",
+    "authors": "Wad67",
    "description": "Strength checks and lifting qualities are no longer required for installing or removing vehicle parts.",
    "category": "rebalance",
    "dependencies": [ "dda" ]
  },

Wad67 · 2018-06-20T01:17:17Z

Okay, done.

BorkBorkGoesTheCode · 2018-06-20T04:36:41Z

The plus is a typo.

Wad67 · 2018-06-20T05:03:08Z

Are you referring to the one in DracoGriffin's example, or some other '+' ?

DracoGriffin · 2018-06-20T05:46:46Z

I think BorkBork was trying to point out my + was a "typo", but I was just trying make sure you saw the line. However, you added the code perfectly so there is no issue with your PR.

BorkBorkGoesTheCode · 2018-06-20T06:45:19Z

I think BorkBork was trying to point out my + was a "typo", but I was just trying make sure you saw the line. However, you added the code perfectly so there is no issue with your PR.

Half correct; I also misinterpreted the plus in the changelog.

Wad67 · 2018-06-20T06:47:08Z

It was a bit confusing given the context, I was under the impression I slipped a plus in by accident as well. A quick check proved otherwise though.

Mecares · 2018-06-20T09:31:21Z

I would like a non game option solution to the problem of limited lifting possibilities, like allow to disassemble a rope and pulley to make your own tripod pulley with a reasonable easy crafting recipe.

Wad67 · 2018-06-20T09:52:45Z

Already an issue for that one, see: #23094
Granitecosmos mentioned they might have something in the works.

kevingranade · 2018-06-20T15:10:30Z

If it's too hard to arrange for a lifting device, just debug one in, or add a handheld lifting device to your mod along with numerous spawn locations for it, or add the lifting quality to heavy sticks. I'm not interested in supporting code to disable arbitrary features scattered throughout the code.

Wad67 · 2018-06-20T16:01:52Z

Fair enough then.

Based on previous attempt: CleverRaven/Cataclysm-DDA#24053

…ng quality) (#42) * Initial implementation of mod Based on previous attempt: CleverRaven/Cataclysm-DDA#24053 * Astyle modinfo.json * do not check aid or strength when installing parts * Astyling * Do not display lifting and strength requirements if disabled Happy to remove the string if needed * No string for disabled requirements Might require further investigation into the display of 'Additional Requirements' * Json Styling Windows defender was preventing make style-json from running correctly * Only display additional requirements if they exist * Show jacking when required, remove irrelevant calculations * Astyle

Wad67 added 6 commits March 18, 2018 22:38

Merge pull request #2 from CleverRaven/master

877434b

Updating tined eating instrument

Merge pull request #3 from CleverRaven/master

3ef592f

The right way round

Restoration of original .gitignore

dc09174

Had to remove 'mods/' temporarily.

Styling

700826d

Fixed up the two if statements that were a bit squashed. Thanks Fuji

Merge branch 'DisableRequirements' of https://github.com/Wad67/Catacl…

17ddf1b

…ysm-DDA into DisableRequirements

Night-Pryanik reviewed Jun 19, 2018

View reviewed changes

Night-Pryanik added Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions labels Jun 19, 2018

Perform check before determining if requirements are satisfied

c763da5

Note that the UI still requires values for qual, lvl and str. I don't intend to alter the UI so that these are not required. But if absolutely required I will attempt to do so.

Wad67 changed the title ~~Optional worldmod to disable lifting requirements~~ Optional worldmod to disable lifting requirements (strength and lifting quality) Jun 19, 2018

Add author

b72cc45

Wad67 closed this Jun 20, 2018

Wad67 added a commit to Wad67/Cataclysm-BN that referenced this pull request Aug 29, 2020

Initial implementation of mod

bca1280

Based on previous attempt: CleverRaven/Cataclysm-DDA#24053

Wad67 mentioned this pull request Aug 29, 2020

Optional worldmod to disable lifting requirements (strength and lifting quality) cataclysmbnteam/Cataclysm-BN#42

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optional worldmod to disable lifting requirements (strength and lifting quality) #24053

Optional worldmod to disable lifting requirements (strength and lifting quality) #24053

Wad67 commented Jun 19, 2018 •

edited

Loading

Night-Pryanik Jun 19, 2018

Wad67 Jun 19, 2018

Night-Pryanik commented Jun 19, 2018

Wad67 commented Jun 19, 2018 •

edited

Loading

NickGrease commented Jun 19, 2018

Wad67 commented Jun 19, 2018

NickGrease commented Jun 19, 2018

Wad67 commented Jun 19, 2018 •

edited

Loading

DoctorGoat commented Jun 19, 2018

NickGrease commented Jun 19, 2018

ghost commented Jun 19, 2018

Leland commented Jun 19, 2018

Wad67 commented Jun 20, 2018

DracoGriffin commented Jun 20, 2018

Wad67 commented Jun 20, 2018

BorkBorkGoesTheCode commented Jun 20, 2018

Wad67 commented Jun 20, 2018

DracoGriffin commented Jun 20, 2018

BorkBorkGoesTheCode commented Jun 20, 2018

Wad67 commented Jun 20, 2018

Mecares commented Jun 20, 2018

Wad67 commented Jun 20, 2018

kevingranade commented Jun 20, 2018 via email

Wad67 commented Jun 20, 2018

Optional worldmod to disable lifting requirements (strength and lifting quality) #24053

Optional worldmod to disable lifting requirements (strength and lifting quality) #24053

Conversation

Wad67 commented Jun 19, 2018 • edited Loading

Night-Pryanik Jun 19, 2018

Choose a reason for hiding this comment

Wad67 Jun 19, 2018

Choose a reason for hiding this comment

Night-Pryanik commented Jun 19, 2018

Wad67 commented Jun 19, 2018 • edited Loading

NickGrease commented Jun 19, 2018

Wad67 commented Jun 19, 2018

NickGrease commented Jun 19, 2018

Wad67 commented Jun 19, 2018 • edited Loading

DoctorGoat commented Jun 19, 2018

NickGrease commented Jun 19, 2018

ghost commented Jun 19, 2018

Leland commented Jun 19, 2018

Wad67 commented Jun 20, 2018

DracoGriffin commented Jun 20, 2018

Wad67 commented Jun 20, 2018

BorkBorkGoesTheCode commented Jun 20, 2018

Wad67 commented Jun 20, 2018

DracoGriffin commented Jun 20, 2018

BorkBorkGoesTheCode commented Jun 20, 2018

Wad67 commented Jun 20, 2018

Mecares commented Jun 20, 2018

Wad67 commented Jun 20, 2018

kevingranade commented Jun 20, 2018 via email

Wad67 commented Jun 20, 2018

Wad67 commented Jun 19, 2018 •

edited

Loading

Wad67 commented Jun 19, 2018 •

edited

Loading

Wad67 commented Jun 19, 2018 •

edited

Loading