[RDY] Bionics installing overhaul #22877

Night-Pryanik · 2018-02-04T19:58:48Z

Added an alternative for manual and instant installing of CBM. Now you can use autodoc for this task.

Player has to be on the couch to perform operation;
~~Autodoc need to be configured prior to use;~~
Autodoc uses player skills and INT to calculate chance of success;
Installation now takes time, duration is based on bionic difficulty. For example, the easiest CBM (Power Storage with difficulty 1) will take twenty minutes to install;
Player falls asleep because of autodoc's anesthesia (abstracted for now). Player should be sure no monster will disturb the operation;
Autodoc spawns at the hospital.

Minor:

Player will now have 0 sight range when sleeping;
Added message when player is falling asleep.

[CR] because I want to know if this approach is good enough.

Questions:

Is autodoc using player skills and INT good? Or should it has some high skill, independent from the player one, removing the need to configure it?
~~Right now autodoc isn't spawned anywhere. Where should it spawn, and how frequent?~~
Should we add explicit anesthesia item, spawn it somewhere, and require to bring it to autodoc? Or we can abstract it like autodoc has it (unlimited?) somewhere in inner storage?
Is dividing this overhaul to several parts (installing, uninstalling, removing manual (un)installing) good?

John-Candlebury · 2018-02-04T20:37:41Z

Ideas for spawning:

-A custom room in labs, similar to the armories and holding cells. Frequently
-Custom room in hospitals. Frequently
-New bionic clinics. Rarely
-Black market clinics in house basements. Rarely

kevingranade · 2018-02-05T01:53:01Z

I can see two major options for installation chance (you essentially have added the first option):

Player programs operation into autodoc.
Outcomes would be based on player int + medical knowledge + programming vs CBM difficulty.
The time to create this program would scale with CBM install difficulty, and might take a very long time.
1. Variation, buy a program from a NPC with better skills.
Player acquires a program for installing a specific CBM (i.e. on a USB stick).
This would have an almost 0 chance of bad outcomes.
This also gives low-int characters a chance of installing, the requirements to just load the software should be very easy.
Players would find these in lab databases, loaded into autodocs, or perhaps rarely elsewhere on USB sticks.
1. This might have qualifications for when it will work, such as not working if the targeted body part is mutated. It will still be safe, but it will refuse to work.

@John-Candlebury covered spawn locations pretty well 👍

I'd like to eventually have anesthesia, surgical tools, bandages, suturing material, etc be consumables for this, but we can get it working first and add those things later.

Just getting installation working first is a great approach, it's by far the most common operation. In particular we don't want to remove the manual operations until this works pretty much perfectly.

inb4 "what about innawoods characters". Your options will eventually be NPC surgeon or an autodoc (or a mod, sure do whatever in a mod), so innawoods characters with NPCs disabled will be unable to access CBMs, and that's fine.

Also filled the room with lockers and racks

Night-Pryanik · 2018-02-05T09:18:12Z

Added autodoc spawn at the previously empty hospital room, also filled it with lockers and racks.

Night-Pryanik · 2018-02-05T09:21:38Z

For now autodoc spawns at the hospital and is working almost fully right (installing bionics still requires painkillers despite autodoc injects anesthesia) for the first step of the overhaul, so I think the PR is ready for the review.

illi-kun · 2018-02-22T08:36:52Z

src/iexamine.cpp

+
+    uimenu amenu;
+    amenu.selected = 0;
+    amenu.text = string_format( _( "Autodoc Mk. XI. Status: %s. Please choose operation." ), status );


. Please
Double whitespace required here.

illi-kun · 2018-02-22T08:38:50Z

src/iexamine.cpp

+    amenu.selected = 0;
+    amenu.text = string_format( _( "Autodoc Mk. XI. Status: %s. Please choose operation." ), status );
+    amenu.addentry( CONFIGURE, true, 'c', str_to_illiterate_str( _( "Configure Autodoc." ) ) );
+    amenu.addentry( INSTALL_CBM, uistate.iexamine_autodoc_config ? true : false, 'i',


uistate.iexamine_autodoc_config ? true : false
can be effectively shorten to just uistate.iexamine_autodoc_config since it's already a boolean variable.

illi-kun · 2018-02-22T08:39:35Z

src/iexamine.cpp

+
+        case INSTALL_CBM: {
+            if( !adjacent_couch ) {
+                popup( _( "No connected couches found. Operation impossible. Exiting." ) );


Double whitespaces after periods required.

illi-kun · 2018-02-22T08:39:44Z

src/iexamine.cpp

+                return;
+            }
+            if( !in_position ) {
+                popup( _( "No patient found located on the connected couches. Operation impossible. Exiting." ) );


here as well.

BevapDin · 2018-02-27T16:39:25Z

src/iexamine.cpp

+    bool adjacent_couch = false;
+    bool in_position = false;
+    for( const auto &couch_loc : g->m.points_in_radius( examp, 1, 0 ) ) {
+        if( g->m.furn( couch_loc ).obj().id == "f_autodoc_couch" ) {


You don't need to get the furn_t object to get its id. map::furn returns an id that you can compare directly. I suggest you store "f_autodoc_couch" as local constant of type furn_str_id and compare it to the result of map::furn.

BevapDin · 2018-02-27T16:40:43Z

src/iexamine.cpp

+            }
+
+            const int bionic = g->inv_for_flag( "CBM", _( "Choose CBM to install" ) );
+            const item &it = p.i_at( bionic );


The two references it and itemtype are only needed below the if block, create them there (right before they are needed).

BevapDin · 2018-02-27T16:42:15Z

src/iexamine.cpp

+
+    switch( static_cast<options>( amenu.ret ) ) {
+        case CONFIGURE:
+            uistate.iexamine_autodoc_config = true;


This is a global variable, setting it will affect all couches all over the world. It's also not saved anywhere, so it's reset whenever the player loads a game.

This is a global variable, setting it will affect all couches all over the world.

Can you recommend something to achieve the desired goal, but only for the couch player interacts with?

Prob you need two furnitures: f_autodoc_unconfigured, f_autodoc_configured.

I'd rather not add another furniture. Anybody know, if there is a way to add flags to furniture during runtime?

kevingranade · 2018-02-28T17:48:31Z

There is not, that's why there are furniture variants for things like open door vs closed door. Your best bet is to drop an item with your state on the same square.

…

On Tue, Feb 27, 2018, 9:40 PM Anton Burmistrov ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/iexamine.cpp <#22877 (comment)> : > + amenu.query(); + + bool adjacent_couch = false; + bool in_position = false; + for( const auto &couch_loc : g->m.points_in_radius( examp, 1, 0 ) ) { + if( g->m.furn( couch_loc ).obj().id == "f_autodoc_couch" ) { + adjacent_couch = true; + if( p.pos() == couch_loc ) { + in_position = true; + } + } + } + + switch( static_cast<options>( amenu.ret ) ) { + case CONFIGURE: + uistate.iexamine_autodoc_config = true; I'd rather not add another furniture. Anybody know, if there is a way to add flags to furniture during runtime? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22877 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0gdKSA65l3SNka8kXxVBGMWM9JE2Hsks5tZOa8gaJpZM4R4suj> .

It will secretly contain `autodoc_config` pseudo item if the player configures the autodoc

…fter player has configured it

Night-Pryanik · 2018-02-28T19:32:55Z

After player configures the autodoc, the game places pseudo item autodoc_config onto the tile with autodoc, which is now behaves like a sealed container with no means of opening. The game then checks for this item, if it exists, then autodoc is considered configured.

BevapDin · 2018-03-06T08:26:55Z

I'd rather not add another furniture. Anybody know, if there is a way to add flags to furniture during runtime?

We don't currently have the infrastructure to store data for a specific place on the map. It's currently solved by having various terrain types (see for example open/closed doors, filled/unfilled kiln).

However, why does the autodoc need to be configure? According to the code, it does nothing, just consumes 3 turns time. This could be done automatically as part of the operation itself. In other words: why are configuration and operation separate steps?

Night-Pryanik · 2018-03-06T14:17:26Z

Well, there's no certain reason. The configuration step is for flavor mostly. I just thought that this will help players feel that they're involved in the process. Should I remove the separate configuration step?

kevingranade · 2018-03-06T16:36:16Z

Yes remove it. This sounds more complicated than its worth.

Night-Pryanik · 2018-03-06T18:48:16Z

Not too much text at once?

Leland · 2018-03-06T19:16:12Z

I think the quantity of text is fine, but I'd probably expect the "Using your knowledge..." text first in that list

Night-Pryanik · 2018-03-07T04:01:33Z

That is because the game first checks if player confirms the installation, and then prints text about knowledge and so on.

Also removed separate blind effect to simulate sleeping

Night-Pryanik · 2018-03-11T07:35:45Z

Moved message about configuring to popup from message in the side log - looks better imo.
Added message when player falls asleep.
Made zero sight range when player is asleep.

Night-Pryanik · 2018-03-26T14:49:34Z

The Using your knowledge... text will appear every time one will install CBM. I think that's not good if this big chunk of text will be repeated time and time again. Maybe bring back the separate configuration step, so the text will be shown only once, and, as I said earlier, it will create base for using the medical software in lieu of manual configuring? I really like the way it looked: configure-then-install.

Leland · 2018-04-16T05:10:49Z

If the quantity of text is an issue, can be shortened:

You type into the console, configuring Autodoc to install a CBM

Night-Pryanik · 2018-04-19T11:00:41Z

The "knowledge" part is important, I think it can help players understand that their skills are playing a role in success chance.

Theundyingcode · 2018-05-21T11:12:37Z

Was reading through the open PRs out of curiosity but I had a thought on this if it's still getting worked on:

Have the Autodoc "run" the installation program from an SD card just like a CNC machine or 3d printer would. (part of iexamine method) The player could find cards with the "official installation program" from the factory or use a laptop or console to encode cards themselves. The official factory made onse would result in near zero failure chance while the outcome of player made ones would be subject to the usual int and skill levels. Requiring a certain level of computers to write the program and/or having it affect the outcomes would be probably be called for in this case.

I'm not familiar with how items are tracked but, given things decay, it should be possible to encode int and relevant skill levels at time of creation. If not, a rather lengthy copy pasted json file would do the trick.

Night-Pryanik · 2018-05-21T11:21:16Z

Using pre-written programs for bionics installation saved on SD cards I consider as next step in this overhaul. At first I just want to make installation work with no errors.

cainiaowu · 2018-06-06T06:32:25Z

This could be changed to [RDY], right?
After 4 month, I guess everyone already said everything about it and it is already good enough.
I really want to see this get merged.

ZhilkinSerg · 2018-06-13T10:05:31Z

Two suggestions for subsequent PRs:

Make possible to select bionics to install from adjacent tiles instead of from player inventory only;
Removed need to take painkillers prior to operation as autodoc injects player with anesthetics too.

Night-Pryanik added 5 commits February 4, 2018 22:30

Added autodoc and autodoc couch furniture

e6776d5

Added CBM flag for all CBMs

735b0ce

Added autodoc iexamine function to iexamine.h

2faf174

Added bool needed for the new autodoc function to uistate.h

4dd0718

Added autodoc iexamine function

965a015

Added autodoc and autodoc couch to hospital mapgen

cf9618d

Also filled the room with lockers and racks

Night-Pryanik changed the title ~~[WIP] [CR] Bionics installing overhaul~~ [CR] Bionics installing overhaul Feb 5, 2018

illi-kun reviewed Feb 22, 2018

View reviewed changes

Double whitespacing, shorten expression

8c9ddd1

BevapDin reviewed Feb 27, 2018

View reviewed changes

Small code changes as per BevapDin's suggestions

523ccf8

Night-Pryanik added 4 commits February 28, 2018 22:03

Make autodoc a sealed container

9ce344e

It will secretly contain `autodoc_config` pseudo item if the player configures the autodoc

Add autodoc_config pseudo item

9207b6b

Game will place autodoc_config pseudo item on the tile with autodoc a…

d7b9cf0

…fter player has configured it

Removed unneeded variable from uistate.h

b689bf1

Always forgetting about inlining

af7ad58

Removed unneeded flags from autodoc

f565b47

Night-Pryanik added 4 commits March 11, 2018 10:16

Moved message about configuring autodoc to popup from message in the log

d45371e

Also removed separate blind effect to simulate sleeping

Removed blind effect declaration

f2bd71e

Sleeping character will now have 0 sight range

a90c260

Added message when player is falling asleep

88537ea

ZhilkinSerg added Bionics CBM (Compact Bionic Modules) Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` (P3 - Medium) Medium (normal) priority labels Apr 2, 2018

Shortened text

9ca6691

Night-Pryanik changed the title ~~[CR] Bionics installing overhaul~~ [RDY] Bionics installing overhaul Jun 6, 2018

Changed sleep duration from int to time_duration

83481d3

ZhilkinSerg self-assigned this Jun 13, 2018

ZhilkinSerg merged commit 809c829 into CleverRaven:master Jun 13, 2018

ZhilkinSerg removed their assignment Jun 13, 2018

Night-Pryanik deleted the bionic-installing-overhaul branch June 13, 2018 19:37

kevingranade mentioned this pull request Dec 29, 2019

Medisoft consumable application #36357

Closed

kevingranade mentioned this pull request Jan 16, 2021

Autodoc installation program which almost guarantees flawless installation of basic-tier bionics #46808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RDY] Bionics installing overhaul #22877

[RDY] Bionics installing overhaul #22877

Night-Pryanik commented Feb 4, 2018 •

edited

Loading

John-Candlebury commented Feb 4, 2018 •

edited

Loading

kevingranade commented Feb 5, 2018

Night-Pryanik commented Feb 5, 2018

Night-Pryanik commented Feb 5, 2018

illi-kun Feb 22, 2018

illi-kun Feb 22, 2018

illi-kun Feb 22, 2018

illi-kun Feb 22, 2018

BevapDin Feb 27, 2018

BevapDin Feb 27, 2018

BevapDin Feb 27, 2018

Night-Pryanik Feb 27, 2018 •

edited

Loading

AMurkin Feb 27, 2018

Night-Pryanik Feb 28, 2018

kevingranade commented Feb 28, 2018 via email

Night-Pryanik commented Feb 28, 2018

BevapDin commented Mar 6, 2018

Night-Pryanik commented Mar 6, 2018

kevingranade commented Mar 6, 2018

Night-Pryanik commented Mar 6, 2018

Leland commented Mar 6, 2018

Night-Pryanik commented Mar 7, 2018

Night-Pryanik commented Mar 11, 2018

Night-Pryanik commented Mar 26, 2018 •

edited

Loading

Leland commented Apr 16, 2018

Night-Pryanik commented Apr 19, 2018

Theundyingcode commented May 21, 2018

Night-Pryanik commented May 21, 2018 •

edited

Loading

cainiaowu commented Jun 6, 2018

ZhilkinSerg commented Jun 13, 2018

[RDY] Bionics installing overhaul #22877

[RDY] Bionics installing overhaul #22877

Conversation

Night-Pryanik commented Feb 4, 2018 • edited Loading

John-Candlebury commented Feb 4, 2018 • edited Loading

kevingranade commented Feb 5, 2018

Night-Pryanik commented Feb 5, 2018

Night-Pryanik commented Feb 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Night-Pryanik Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevingranade commented Feb 28, 2018 via email

Night-Pryanik commented Feb 28, 2018

BevapDin commented Mar 6, 2018

Night-Pryanik commented Mar 6, 2018

kevingranade commented Mar 6, 2018

Night-Pryanik commented Mar 6, 2018

Leland commented Mar 6, 2018

Night-Pryanik commented Mar 7, 2018

Night-Pryanik commented Mar 11, 2018

Night-Pryanik commented Mar 26, 2018 • edited Loading

Leland commented Apr 16, 2018

Night-Pryanik commented Apr 19, 2018

Theundyingcode commented May 21, 2018

Night-Pryanik commented May 21, 2018 • edited Loading

cainiaowu commented Jun 6, 2018

ZhilkinSerg commented Jun 13, 2018

Night-Pryanik commented Feb 4, 2018 •

edited

Loading

John-Candlebury commented Feb 4, 2018 •

edited

Loading

Night-Pryanik Feb 27, 2018 •

edited

Loading

Night-Pryanik commented Mar 26, 2018 •

edited

Loading

Night-Pryanik commented May 21, 2018 •

edited

Loading